Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Refactored extract hierarchy plugin #4139

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Nov 25, 2022

Brief description

Refactored extract hierarchy plugin.

Description

Changed extract hierarchy plugin to not use recursions but be queue based. Updates of entities does not override full data on entity but only modified or new keys. Asset update is not skipped if new entity should not have tasks. Asset on instance is updated with new data on it even if was prefilled before. Prequery documents at once instead of one by one.

Additional information

There is still missing validation of changing parents or possible change of name of asset. That should be added in future too.

Testing notes:

Editorial publishing should create/update entities without any issues.

  1. Creation of assets should work as expected
  2. Updating of assets should work as expected
  3. Creation of assets without tasks should not cause any weird data on asset

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 25, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Nov 25, 2022
@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review November 25, 2022 12:18
@iLLiCiTiT iLLiCiTiT merged commit 7e2400d into develop Dec 1, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/extact_hierachy_enhancements branch December 1, 2022 09:16
@github-actions github-actions bot added this to the next-patch milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants