Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Standalone Publish Directories #4148

Merged

Conversation

2-REC
Copy link
Contributor

@2-REC 2-REC commented Nov 29, 2022

Brief description

Dropped directories in the Standalone Publish tool are not handled.

Description

When dropping a directory in the Standalone Publish tool, the content of the directory is not expanded.

The publish then crashes during the integration (in the "integrate_new" plugin) with an "Access Denied" error.

The fix is however already present, but not used (call to the _get_all_paths function).

Additional info

The error is due to the copyfile function being called with a directory as the src parameter (though a file is expected).

The code already contains the fix to expand the directories:

paths = self._get_all_paths(in_paths)

However, the newly created list paths is not used in the following for loop:

for path in in_paths:
   ...

Testing notes:

  1. Open the Standalone Publish tool.
  2. Select a project, asset, task and family.
  3. Drop a directory in the "drop zone".
  4. Publish
  5. The error [WinError -2147024891] Access Denied (in Windows using "speedcopy") or [WinError 13] Access Denied is raised.

@iLLiCiTiT iLLiCiTiT merged commit c1437c0 into ynput:develop Nov 29, 2022
@github-actions github-actions bot added this to the next-patch milestone Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants