Fix: Standalone Publish Directories #4148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Dropped directories in the Standalone Publish tool are not handled.
Description
When dropping a directory in the Standalone Publish tool, the content of the directory is not expanded.
The publish then crashes during the integration (in the "integrate_new" plugin) with an "Access Denied" error.
The fix is however already present, but not used (call to the
_get_all_paths
function).Additional info
The error is due to the
copyfile
function being called with a directory as thesrc
parameter (though a file is expected).The code already contains the fix to expand the directories:
However, the newly created list
paths
is not used in the followingfor
loop:Testing notes:
[WinError -2147024891] Access Denied
(in Windows using "speedcopy") or[WinError 13] Access Denied
is raised.