Feature/213 move pyblish to tools #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
./pype/tools/pyblish_pype/model.py:979:34: B008: Do not perform function call...
./pype/tools/pyblish_pype/model.py:979:34: B008: Do not perform function calls in argument defaults. The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call. If this is intended, assign the function call to a module-level variable and use that variable as a default value. ./pype/tools/pyblish_pype/model.py:983:31: B008: Do not perform function calls in argument defaults. The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call. If this is intended, assign the function call to a module-level variable and use that variable as a default value. ./pype/tools/pyblish_pype/model.py:1008:41: B008: Do not perform function calls in argument defaults. The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call. If this is intended, assign the function call to a module-level variable and use that variable as a default value.
| # Determine minimum indentation (first line doesn't count): | ||
| try: | ||
| indent = sys.maxint | ||
| max = sys.maxint |
There was a problem hiding this comment.
sys.maxint is not a thing on Python 3. Use sys.maxsize.
| lines = docstring.expandtabs().splitlines() | ||
| # Determine minimum indentation (first line doesn't count): | ||
| try: | ||
| indent = sys.maxint |
There was a problem hiding this comment.
sys.maxint is not a thing on Python 3. Use sys.maxsize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.