Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated -intra parameter in ffmpeg to new -g #417

Merged
merged 1 commit into from Aug 7, 2020
Merged

deprecated -intra parameter in ffmpeg to new -g #417

merged 1 commit into from Aug 7, 2020
+3 −0

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Aug 7, 2020 •
edited

Issue

  • output from burnin script has wrong keyframes

Suggested solution

  • add ffmpeg argument -g 1 (replacement of deprecated -intra) in burnin script so output should have right keyframes

Warnings

  • @jezscha can you test it as you have ready testing data
  • @mkolar PR is to master, is it OK?

@iLLiCiTiT iLLiCiTiT self-assigned this Aug 7, 2020
@mkolar mkolar changed the base branch from master to 2.x/develop August 7, 2020 13:18
@mkolar mkolar changed the title Bugfix/ffmpeg intra in burnins change deprecated -intra parameter in ffmpeg to new -g Aug 7, 2020
@mkolar mkolar added the type: bug Something isn't working label Aug 7, 2020
@mkolar mkolar added this to the 2.12 milestone Aug 7, 2020
@mkolar mkolar merged commit 7e12f02 into 2.x/develop Aug 7, 2020
@mkolar mkolar changed the title change deprecated -intra parameter in ffmpeg to new -g deprecated -intra parameter in ffmpeg to new -g Aug 11, 2020
@mkolar mkolar deleted the bugfix/ffmpeg_intra_in_burnins branch September 9, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

@mkolar mkolar Awaiting requested review from mkolar

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
2.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iLLiCiTiT @mkolar