Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Tiled EXRs to scanline EXRs render option #512

Merged
merged 8 commits into from Oct 6, 2020

Conversation

antirotor
Copy link
Member

Feature

Added new option to Maya render instance Convert to scanline. When checked, it will convert produced tiled EXRs to scanline EXRs as new representation. Useful when tiled renders are required because of heavy scene but compositing apps are having problems with it or are slow reading tiled EXRs.

EXRs are converted during publishing phase.

Requires OpenImage IO

⚠️ Requires: PYPE_OIIO_PATH environment variable pointing to oiiotool binary

@mkolar
Copy link
Member

mkolar commented Sep 22, 2020

This is a bit strange rigth now. It keeps both representations in DB exr and exr_scanline but they both point to the same file.

I think we could keep just exr to prevent complications. we're not putting compression name into the repre name either.

Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the comment about the representations

@antirotor
Copy link
Member Author

I think this is because integrator integrates both representations under same name - and that is problem by its own, isn't it? It differentiate only on representation extension key {representation}. But I think it is completely ok to want to have multiple types of the same image format in representations. So:

[
    {
        "name": "exr_scanline",
        "ext": "exr"
    }, {
        "name": "exr_tiled",
        "ext": "exr"
    }
]

When this happens I guess last representation with same ext wins.

@mkolar
Copy link
Member

mkolar commented Sep 24, 2020

That depends on a publishing template. We have the optional <output> key which some extractors use for differentiating between various representations. Part of the problem is the discrepancy between anatomy representation and extension in the representation data. These should be the same and in anatomy should be optionally mapped to representation["name"]

at this moment. the best would be to approach this the same way as quicktimes from extract review, by adding output key to the representation data so it get's picked up by the integrator.

@antirotor
Copy link
Member Author

This will now move files to temporary names and convert to original names with OIIO. No new representation. Same files (almost as they are tiled 👉 scanline converted) at the same place.

@antirotor antirotor requested a review from mkolar October 1, 2020 14:23
@mkolar
Copy link
Member

mkolar commented Oct 1, 2020

I'm still getting the scanline in the file names
image

it needs to be popped from representation['output'] key

@mkolar mkolar added this to the 2.13 milestone Oct 6, 2020
@mkolar mkolar merged commit f2ed187 into 2.x/develop Oct 6, 2020
@mkolar mkolar deleted the feature/tiled-exr-to-scanline branch October 13, 2020 21:25
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Oct 18, 2020
@BigRoy BigRoy mentioned this pull request Apr 5, 2023
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Maya type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants