Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use grouped version updates for Dependabot #15909

Open
shenxianpeng opened this issue May 6, 2024 · 6 comments · Fixed by #15920
Open

Use grouped version updates for Dependabot #15909

shenxianpeng opened this issue May 6, 2024 · 6 comments · Fixed by #15920
Labels
dependencies Pull requests that update a dependency file developer experience Anything that improves the experience for Warehouse devs feature request

Comments

@shenxianpeng
Copy link
Contributor

shenxianpeng commented May 6, 2024

What's the problem this feature will solve?

There are many pull requests for python dependency updates created by dependabot and then they are closed by github/ composite-prs, see #15907, and there are also a lot of notifications generated for watchers of the project.

image

Describe the solution you'd like

It may be best to use grouped version updates for Dependabot

As mentioned above is this README, a core reason why this Action exists is to "combine multiple Dependabot PRs into one". Work for this Action was completed before the GitHub Blog Post was published and the Dependabot Grouped Version Updates feature was released.

And it also be mentioned in the README page of combine-prs as above.

For example if use groups, it will be work like this: jenkinsci/kubernetes-operator#1004

I see that groups seems to be used in dependabot.yml, but not for against all python dependencies, not sure why? and it doesn't seem to work. Maybe I'm mistaken.

@shenxianpeng shenxianpeng added feature request requires triaging maintainers need to do initial inspection of issue labels May 6, 2024
@miketheman miketheman added developer experience Anything that improves the experience for Warehouse devs dependencies Pull requests that update a dependency file and removed requires triaging maintainers need to do initial inspection of issue labels May 6, 2024
@miketheman
Copy link
Member

Hi @shenxianpeng !

Thanks for the suggestion - as you can see, we use the groups specifically for dependencies that should be updated together.

Thanks for sharing the jenkinsci link - beyond that example, can you share your experience with grouped updates?

Is the main issue here that you're receiving many notifications? That's something you can tailor on your end - wither by changing the Watching settings, or even applying an email filter.

@shenxianpeng
Copy link
Contributor Author

shenxianpeng commented May 7, 2024

Hi @miketheman thanks for your reply!

In my view, the main problem is that a large number of pull requests are created and closed for each bump. The more natural way would be to create a pull request with grouped updates and then review and merge them. Using the groups function would be more elegant than using github/ composite-prs.

@miketheman
Copy link
Member

Hey @shenxianpeng ! Thanks for the perspective.

I don't have time to tinker with this right now, but if you wanted to send a pull request with the desired changes, I'll gladly take a look.

@shenxianpeng
Copy link
Contributor Author

Yes. I will @miketheman

@miketheman
Copy link
Member

After merging the changes, I've both seen the automatic job run as well as a manual trigger - and they both time out after ~1 hour.

Individual updates take about ~3-4 minutes to run.

Here's a docs section on timeouts and what to do for them: https://docs.github.com/en/code-security/dependabot/working-with-dependabot/troubleshooting-dependabot-errors#dependabot-timed-out-during-its-update

It may be best us to revert the changes for now and restore the manual combine job.

@shenxianpeng
Copy link
Contributor Author

It may be best us to revert the changes for now and restore the manual combine job.

Yes, agree. sorry for the inconvenience. I'll use the fork repository of warehouse to look at that later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file developer experience Anything that improves the experience for Warehouse devs feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants