Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Gitub Actions workflow to build, check and deploy to PyPI #76

Closed
wants to merge 1 commit into from

Conversation

dvandyk
Copy link
Collaborator

@dvandyk dvandyk commented Feb 20, 2021

  • Uses the manylinux2014 docker image. I use the same for EOS. Can be changed later to e.g. manylinux2010 or even manylinux1?
  • Builds for python3 only. Do we really need python2.x?
  • Builds wheel for every commit, but only deploys to PyPI for tagged commits.
  • Builds and deploys documentation for every commit. Should this step deploy only on tagged commits?

@dvandyk
Copy link
Collaborator Author

dvandyk commented Feb 20, 2021

Hm, apparently the actions are only run once the workflow is committed to this repository. Can I get push access to the branch 'testing'?

@fredRos
Copy link
Collaborator

fredRos commented Feb 20, 2021

Hm, apparently the actions are only run once the workflow is committed to this repository. Can I get push access to the branch 'testing'?

I actually got the travis integration working again, see https://travis-ci.org/github/fredRos/pypmc/jobs/759802045 But we have to fix the doc deployment, also relates to the secrets etc. I would actually like docs to be deployed for every commit. So I'm not sure what the benefit of the github action is then.

We should only have one of the two services enabled

@fredRos
Copy link
Collaborator

fredRos commented Feb 21, 2021

@dvandyk I'm closing this PR for now to clean the house so there is no PR open before migrating the repo. Please open it again in the new home, then you can configure the secrets and everything. Should be much simpler for both of us

@fredRos fredRos closed this Feb 21, 2021
@dvandyk
Copy link
Collaborator Author

dvandyk commented Feb 21, 2021

Sounds reasonable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants