Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the default chromium version "588429" is too old, it's better to change a new one. #291

Closed
heliping opened this issue Jul 30, 2021 · 3 comments

Comments

@heliping
Copy link

My web site said the chromium can't support, I changed a newer chromium version. need update the __init__py ---> chromium_revision .

@zak427zak
Copy link

I agree, I faced the same problem

@Mattwmaster58
Copy link
Member

Mattwmaster58 commented Aug 15, 2021

One can easily change the env variable PYPPETEER_CHROMIUM_REVISION to download whatever revision they please. Until a proper test suite is being used, this can't safely be addressed in my mind, especially with the presence of the aforementioned work-around. A codebase rework and new tests will come around the same time so I'm closing this for now.

REVISION = os.environ.get('PYPPETEER_CHROMIUM_REVISION', __chromium_revision__)

@vee-varun
Copy link

Refer to this doc to see how to update chromium version in pyppeteer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants