Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snakemake workflow #1

Merged
merged 6 commits into from Jan 23, 2022
Merged

Add snakemake workflow #1

merged 6 commits into from Jan 23, 2022

Conversation

pz-max
Copy link
Member

@pz-max pz-max commented Jan 22, 2022

@stephenjlee , First of all: COOL TOOL 馃挴. I added in this PR a first snakemake workflow to the package. This makes execution easy on local and cluster machines, and is useful if one wants to add more options, other workflows, or packages.

Further changes:

  • unfix the conda environment to stay updated (recommended)
  • remove the PROJECT_PATH, CACHE_PATH, OUT_PATH as do some os.path setting instead
  • automatic creation of /out and /cache folders

I am keeping this here as a Pull Request. Feel free to test it on my branch and request changes if necessary. This PR is also not urgent, we can talk about it at the next meeting.

- bring environment up to date
- add workflow infrastructure
- adjust download script with path setting
- adjust paths
- fix readme
- add workflow components
@stephenjlee stephenjlee merged commit 9c7e022 into pypsa-meets-earth:main Jan 23, 2022
@stephenjlee
Copy link
Contributor

Brilliant - thanks for the improvements! Snakemake looks like a promising standard, conda unfix is great, and automatic creation of folders is convenient.

I'm accepted your changes to: "remove the PROJECT_PATH, CACHE_PATH, OUT_PATH as do some os.path setting instead" for consistency, but I'm not convinced this is an improvement. I suspect python-dotenv may give more flexibility with only marginally higher overhead. I'd be keen to discuss and potentially lobby for python-dotenv.

@pz-max
Copy link
Member Author

pz-max commented Jan 23, 2022

@stephenjlee happy to learn more about the python-dotenv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants