-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing of regions management when loading OSM data #249
Conversation
@davide-f, could you please have a look on the PR? I think it's mainly done. The test of OSM data load across the globe were generally successful, but there were some local problems:
|
Hi @ekatef , good job! I answer point by point below:
|
Hi @davide-f , many thanks for checking!
Yes, exactly: some OSM data for Somalia and Guinea-Bissau are available (and pbf files are being loaded by With Guyane there it seems to be naming troubles. Strictly speaking, GeoFabrik page on guyane relates to French Guiana = "GF" while GeoFabrik data related to Co‑operative Republic of Guyana = "GY" I was not able to find.
That seems to be connected with data frame subsetting here: For some areas subsetting |
Thank you for your comments. Thanks @ekatef ! |
@davide-f, thank you for the review and merging. Great to know that this point is done :) Ok, I'll add an issue related to troubles with structure of data frames extracted from OSM. Apart of the KeyErrors in |
Testing of regions management when loading OSM data
Changes proposed in this Pull Request
This pull request aims to test management of different world countries and regions when downloading OSM data.
The goals are
world_iso
world_geofk
continent_regions
dictionary used to define macro-regionsTest by continents and regions
Let's see how the workflow runs if OSM data are loaded for different regions of the world. The macro region shortcuts for testing are defined according to the config_osm_data.continent_regions
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes.