Add load changes - dynamic file choice based on user parameters #275
Conversation
pz-max
changed the title
|
based on PR #218 |
|
@davide-f implemented your suggestion, please have a look. Just some weird CI issues remaining... Any idea how to deal with them? |
|
@giacfalk FYI, just about to finalize your contribution. Thanks for adding this feature 👍 |
There was a problem hiding this comment.
Hi there!
Thanks for your PR. @pz-max asked me to review it as I was also responsible for creating the demand datasets in the first place ;-).
There are a few things that need attention, some that should be given attention, and some that could be given attention. See the specific comments.
|
Great thanks @euronion for the concise feedback. We will address all of the points very soon 👍🏽 |
…rs (#289) * Restyled by autopep8 * Restyled by black * Restyled by isort * Restyled by reorder-python-imports * Restyled by whitespace * Restyled by yapf Co-authored-by: Restyled.io <commits@restyled.io>
…frica into giacfalk-main
|
@euronion just adressed all requested changes whcih are passing the tests. Let me know if I am missing something important or if you have any further recommendations. :) |
I guess no. It's just required for the Snakefile. I see this function as well as the demand stuff moving to a new .py script in future. Let's talk about that maybe at the next workflow meeting? |
Add load changes - dynamic file choice based on user parameters
Closes # (if applicable).
Changes proposed in this Pull Request
Checklist
envs/environment.yamlandenvs/environment.docs.yaml.config.default.yaml,config.tutorial.yaml, andtest/config.test1.yaml.doc/configtables/*.csvand line references are adjusted indoc/configuration.rstanddoc/tutorial.rst.doc/release_notes.rstis amended in the format of previous release notes.