Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up data and resources #1020

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Cleaning up data and resources #1020

merged 4 commits into from
Apr 15, 2024

Conversation

toniseibold
Copy link
Contributor

@toniseibold toniseibold commented Apr 11, 2024

Only cosmetic changes. Raw files are stored in the data folder, as soon as a rule creates or changes a file it is moved to resources.

Data folder

The following files are deleted

  • data/hydrogen_salt_cavern_potentials.csv
  • data/heat_load_profile_DK_AdamJensen.csv

@fneum: the following data from zenodo is not used anymore

  • data/bundle/
    • EIA_hydro_generation_2000_2014.csv
    • time_series_60min_singleindex_filtered.csv
  • data/bundle-sector
    • JRC Biomass Potentials.xlsx
    • eurostat-energy_balances-june_2016_edition
    • eurostat-energy_balances-june_2017_edition
    • eurostat-energy_balances-june_2018_edition
    • WindWaveWEC_GLTB.xlsx

Resources folder

following file is deleted

  • resources/eia_hydro_stats.csv is not used

open for discussion @fneum

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@toniseibold toniseibold requested a review from fneum April 12, 2024 08:29
@fneum
Copy link
Member

fneum commented Apr 14, 2024

The changes look good.

The cost file is in the resources directory as it depends on the configuration file and, therefore, can be scenario-dependent. This is because the link can point to a different technology-data version specified in the config.yaml.

The resources/heat_totals.csv is used in build_population_weighted_energy_totals (but it's a bit hidden through the {kind} wildcard as this rule shares the distribution to nodes by population across heat_totals.csv and energy_totals.csv.

I will update and compress the data bundles.

@fneum fneum marked this pull request as ready for review April 15, 2024 09:24
@fneum fneum merged commit a4d58b7 into master Apr 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants