Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve agg_p_nom_limits configuration #1023

Merged
merged 4 commits into from
May 20, 2024

Conversation

tgi-climact
Copy link
Contributor

Changes proposed in this Pull Request

Improved the behaviour of agg_p_nom_limits:

  • Moved the associated configuration to solving. This allows Snakemake to correctly decide which rules to run when the configuration changes.

  • Added the ability to enable aggregation of all offwind types (offwind-ac and offwind-dc) when writing the constraint.

  • Added the possibility to take existing capacities into account when writing the constraint.

  • Added the possibility to have a different file for each planning horizon.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

…into account in solve_network

# Conflicts:
#	scripts/solve_network.py
@tgi-climact
Copy link
Contributor Author

@FabianHofmann Would it be useful to add some code to extend this feature to links ? e.g. write constraint into agg_p_nom_minmax.csvfor nuclear

@fneum fneum added this to the v0.11.0 milestone May 12, 2024
@fneum
Copy link
Member

fneum commented May 20, 2024

@tgi-climact all looks good!

Yes, I think it makes sense to extend this feature to links. I'll merge this PR first, and then we can extend.

@fneum fneum merged commit 65b05e9 into PyPSA:master May 20, 2024
4 of 5 checks passed
@tgi-climact tgi-climact deleted the feature/enhance-agg-p-nom-limits branch May 21, 2024 07:06
@tgi-climact
Copy link
Contributor Author

@tgi-climact all looks good!

Yes, I think it makes sense to extend this feature to links. I'll merge this PR first, and then we can extend.

Great, I will propose a new PR when I have some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants