Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connection costs output #1031

Merged
merged 2 commits into from Apr 18, 2024
Merged

Remove connection costs output #1031

merged 2 commits into from Apr 18, 2024

Conversation

martacki
Copy link
Member

Changes proposed in this Pull Request

Suggest to remove the snakemake output for connection costs, because it creates bugs if a selection of countries is taken that does not contain links, and remove_stubs is set to false.

Also, UA is not part of the synthetic load data, so removing UA there. I noticed the connection_costs bug when running UA only which is why I'm combining those two bugfixes here.

workflow tested also with config.default (all countries) for power and all other sectors.

I'm not aware of any need of the output in other rules.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@martacki martacki added the bug label Apr 16, 2024
@koen-vg
Copy link
Contributor

koen-vg commented Apr 17, 2024

I guess this actually fixes #843 too?

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! This output is never used.

@fneum fneum merged commit 95805a8 into master Apr 18, 2024
5 checks passed
@fneum fneum mentioned this pull request Apr 18, 2024
2 tasks
@martacki
Copy link
Member Author

I guess this actually fixes #843 too?

awesome!

@martacki martacki deleted the remove_connection_costs branch April 18, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants