-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing biomass transport cost #769
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the currently suggested changes, the script cannot be compiled on Linux. We're working on a fix.
Hello, @martacki. I have added encoding based on the OS. For Windows it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Linux, seems to run.
The script is furthermore not touched with the default config configuration, only when biomass_transport = True
for more information, see https://pre-commit.ci
Changes proposed in this Pull Request
Good day. Here I propose changes to
build_biomass_transport_costs.py
file to fix the error that happens whenbiomass_transport
is set true in the config. I have uploaded the error. It is related to utf-8 encoding, in particular, the error happens due to EUR sign. I run my code in the windows machine. The error is resolved by explicitly defining encoding ascp1252
which is a windows compatible encoding and an extension oflatin-1
encoding. After I have fixed the code, I have checked the resulting csv. The resulting biomass transport costs coincides with the supplementary material in Liza's paper on "Mitigating heat demand ...".Checklist
doc/release_notes.rst
is added.