Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Land transport fix #957

Merged
merged 39 commits into from
May 15, 2024
Merged

Land transport fix #957

merged 39 commits into from
May 15, 2024

Conversation

lisazeyen
Copy link
Contributor

@lisazeyen lisazeyen commented Mar 4, 2024

Changes proposed in this Pull Request

This PR converts all land transport demand to one single node and adds the different land transport options (EV, fuel cell, internal combustion car) as links.

This is a bug fix since currently efficiency are adjusted with the assumptions that all cars would be EVs (what is not the case for myopic optimisation) and is a preparation for endogenousing the land transport.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@lisazeyen lisazeyen mentioned this pull request Mar 4, 2024
6 tasks
@lisazeyen lisazeyen marked this pull request as ready for review March 6, 2024 08:33
@lisazeyen lisazeyen requested a review from fneum March 6, 2024 08:33
@lisazeyen lisazeyen requested a review from p-glaum March 14, 2024 19:13
@lisazeyen
Copy link
Contributor Author

just a ping for @fneum or maybe @p-glaum can have a look?

@lisazeyen lisazeyen requested a review from martavp April 15, 2024 06:39
@fneum fneum added this to the v0.11.0 milestone May 12, 2024
@fneum fneum merged commit 44fb8ca into master May 15, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants