Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

在抓我的最愛的時候,碰到分隔線就不繼續往下抓看板了 #81

Closed
openopentw opened this issue Apr 15, 2021 · 1 comment
Assignees
Labels

Comments

@openopentw
Copy link
Contributor

如題,在抓我的最愛的時候,碰到分隔線就不繼續往下抓看板了。

例如我的最愛是這樣:
圖片

使用 get_favourite_board() 的話只會抓到這些:

b04902xxx
b98902HW
EE_Comment
----------
NTU
NTUcourse
----------

後面的 Master_D 跟 Graduate 都沒有抓到。

原因應該是因為這一行(PyPtt/_api_get_favourite_board.py#L77):

if board in board_list:
    return favourite_board_list

因為分隔線重複出現了,但其實分隔線不是板名,所以不應該就這樣停下,我建議可以改成這樣:

if board != '----------' and board in board_list:
    return favourite_board_list

我在本機實測這樣是可以抓完的。

@PttCodingMan PttCodingMan self-assigned this May 8, 2021
@PttCodingMan
Copy link
Member

PttCodingMan commented May 8, 2021

Fixed at PyPtt-0.9.47.

Please check the change in PttCodingMan@4b0d591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants