Retry decorator not supports substitution at max

[Reskov]

Seems like retry_decorator does not happy with dynamic context values that need substitution

steps:
  - name: pypyr.steps.py
    retry:
      max: !py '3'
    in:
      pycode: 'raise ValueError("booom!")'

Will produce

retry: ignoring error because retryCounter < max.
ValueError: booom!
retry: ignoring error because retryCounter < max.
ValueError: booom!
retry: ignoring error because retryCounter < max.
ValueError: booom!

Contrary to original which works well

steps:
  - name: pypyr.steps.py
    retry:
      max: 3
    in:
      pycode: 'raise ValueError("booom!")'

retry: ignoring error because retryCounter < max.
ValueError: booom!
retry: ignoring error because retryCounter < max.
ValueError: booom!
Error while running step pypyr.steps.py at pipeline yaml line: 2, col: 5
Something went wrong. Will now try to run on_failure.

The cause:
On the exec_iteration we are still checking self.max which has a raw value

pypyr/pypyr/dsl.py

Line 821 in dc95053

if counter == self.max:

pypyr/pypyr/dsl.py

Line 881 in dc95053

max = context.get_formatted_as_type(self.max, out_type=int)

Can we support for substitution on the max property?

[yaythomas]

Excellent, great find! Thank you so much!