Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wanted] Battle testers #59

Closed
Pyrdacor opened this issue Nov 17, 2020 · 20 comments
Closed

[Wanted] Battle testers #59

Pyrdacor opened this issue Nov 17, 2020 · 20 comments

Comments

@Pyrdacor
Copy link
Owner

First implementation of battles is out there.

Please start testing battles with v1.1.18. Report bugs here so I won't get drowned in oceans of bugs. :D This is still beta and will have many flaws.

Spells are not implemented yet as well as advancing the group. So don't report issues regarding these features.

@jr-riketz
Copy link

Battle gestartet, funktioniert ganz gut Bewegungen soweit ok.
nach ca. 1,5 Minuten stürzt das Spiel unverhofft ab.
nach nun 10 Kämpfen mal nach einem Lauf Befehl, mal nach einem Angriffsbefehl. willkürlich

@Pyrdacor
Copy link
Owner Author

Thanks for reporting this. Is there an error message after the crash?

@jr-riketz
Copy link

Thanks for reporting this. Is there an error message after the crash?

Its a Crash no Error Message

@Pyrdacor
Copy link
Owner Author

1.1.19 fixes some things. Please give it a try.

@jr-riketz
Copy link

stuck_after_escape

Battle Crash is gone! nice Job

New Problem:
The enemy has run away.
Subsequently, the fight was not ended.
When I tried to run away with all the characters, I got stuck in this window.
I couldn't close it so I had to quit the game.

Greetz J

@jr-riketz
Copy link

stuck_after_escape

Battle Crash is gone! nice Job

New Problem:
The enemy has run away.
Subsequently, the fight was not ended.
When I tried to run away with all the characters, I got stuck in this window.
I couldn't close it so I had to quit the game.

Greetz J

i tried about 20 fights, this scenario where the enemy runs away is apparently the trigger.

The fight mode should actually be ended here.

@Pyrdacor
Copy link
Owner Author

Alright. I will look into it tomorrow. Thanks for testing.

@Pyrdacor
Copy link
Owner Author

I fixed your issue and others regarding fleeing as well. But next release will only come in a few days or maybe tomorrow.

@Pyrdacor
Copy link
Owner Author

The battle should end now when all monsters or the party flee.

I added the first test spell. You can click on the "use magic" button with any party member. Then click on a target monster on the battle field. The spell fire ball is then performed.

Note: There is no spell list popup yet. And the spell does no real damage at the moment. But the animations should be displayed.

@jr-riketz
Copy link

Nice Spell animation, thanks for that.

Issue i just saw:

I killed a bandit in town and after he died his disappearing animation was two blocks behind his original position.

I tried to capture this in a picture, I think you know what I mean.
PS: The second picture was from another fight in which this also happened, hence the shift to the right, the disappearing animation.
before
after

Problem is the Same in the last 20 Battles.

Greetz J

@jr-riketz
Copy link

Another little question:
At the beginning of the fireball magic, the play area is briefly colored red.
I wanted it that way, I can't even remember it.
;-)

@jr-riketz
Copy link

The battle should end now when all monsters or the party flee.

I added the first test spell. You can click on the "use magic" button with any party member. Then click on a target monster on the battle field. The spell fire ball is then performed.

Note: There is no spell list popup yet. And the spell does no real damage at the moment. But the animations should be displayed.

Nice that you thought that warriors do not cast spells and that it is deactivated for these players.

@Pyrdacor
Copy link
Owner Author

I will have a look at the displacement issue in the coming week
Thanks for reporting.

Yeah the screen is colored red briefly in original game. So I added it as well. The screen is briefly colored blue for ice spells. This is also prepared already.

About the warrior cast thing. Yeah I try my best to implement every single detail of the original game. And there are lots of them. Most things are drawn pixel perfect (at the same pixel as in original) and I do this by taking screenshots and measure it by hand. So it is much more work than it may look like. I really love the game so I want the best for the rework as well and give all the great memories to all who cherished the original or love retro games and their details.
I am glad that you pointed it out and like it. This is the reason why I am doing this. :)

@Pyrdacor
Copy link
Owner Author

Pyrdacor commented Dec 4, 2020

I could need some help in finding out the exact damage values of spells. I did already for the 4 fire spells but the rest needs testing. I also don't know if the damage is dependent on the caster and/or the target. The latter one didn't seem the case for my fire spell tests which I performed on gargoyles, gigantula, poison spider and small spider.

@Thallyrion
Copy link

Thallyrion commented Dec 4, 2020

What exactly did you find out about the damage values of the Fire spells? Do they correspond to the damage values stated in the manual?

I just tested a battle and got a crash: v0.1.0 beta

Object reference not set to an instance of an object.
at Ambermoon.Game.<>c__DisplayClass261_0.g__EndBattle|8(BattleEndInfo battleEndInfo)
at Ambermoon.Game.<>c__DisplayClass261_1.b__9()
at Ambermoon.Game.ShowBattleLoot(BattleEndInfo battleEndInfo, Action closeAction)
at Ambermoon.Game.<>c__DisplayClass261_0.b__4(BattleEndInfo battleEndInfo)
at Ambermoon.Battle.KillMonster(PartyMember attacker, Character target)
at Ambermoon.Battle.<>c__DisplayClass91_0.b__1()
at Ambermoon.Battle.<>c__DisplayClass116_0.g__FinishEffect|0()
at Ambermoon.Battle.<>c__DisplayClass117_0.g__EffectAnimationFinished|0()
at Ambermoon.Render.BattleAnimation.Update(UInt32 ticks)
at Ambermoon.Battle.Update(UInt32 battleTicks)
at Ambermoon.Game.UpdateBattle()
at Ambermoon.Game.Update(Double deltaTime)
at Silk.NET.Windowing.Desktop.GlfwWindow.RaiseUpdateFrame()
at Silk.NET.Windowing.Desktop.GlfwWindow.DoUpdate()
at Silk.NET.Windowing.Common.WindowExtensions.<>c__DisplayClass2_0.b__0()
at Silk.NET.Windowing.Desktop.GlfwWindow.Run(Action onFrame)
at Silk.NET.Windowing.Common.WindowExtensions.Run(IView view)
at Ambermoon.GameWindow.Run(Configuration configuration)
at Ambermoon.Program.Main()

@Pyrdacor
Copy link
Owner Author

Pyrdacor commented Dec 4, 2020

@Thallyrion: About the crash: How many members had your party? Less than 6?

@Pyrdacor
Copy link
Owner Author

Pyrdacor commented Dec 4, 2020

I couldn't find any information about spell damage in the manual nor on the web.

@Thallyrion
Copy link

Thallyrion commented Dec 4, 2020

Indeed i think i mixed it up with amberstar game where spelldamage was included in the manual. But maybe it could still be usefull to check if the values correspond to them.

My Party had 2 Members

@Pyrdacor
Copy link
Owner Author

Pyrdacor commented Dec 4, 2020

The spell damage in Amberstar seems to be very different. In Ambermoon the strongest spells are the ice spells, then the fire spells, then wind and then earth. In Amberstar fire and ice/water spells are weak in relation to wind or earth spells. Fireball is stated as 4-8 damage. In Ambermoon I found a range of 40-80. Wind devil is given with 16-32 in Amberstar but I found a range of 10-15 in Ambermoon. So I guess we could not rely on Amberstar here.

@Pyrdacor
Copy link
Owner Author

Pyrdacor commented Dec 4, 2020

Crash should be fixed in 0.1.1beta. Moreover the firepillar spell is now available and the death animations of monsters should be corrected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants