Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D Map Issue Thieves Hideout #7

Closed
Thallyrion opened this issue Aug 18, 2020 · 9 comments
Closed

2D Map Issue Thieves Hideout #7

Thallyrion opened this issue Aug 18, 2020 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@Thallyrion
Copy link

Enter first floor of the Thieves Hideout. You can't leave. Stairs down don't work.

thieves hideout 1st floor

@Pyrdacor
Copy link
Owner

This also happens with the fire place in grandfathers house. Every map uses chained map events per tile. At the moment only the first one is executed. If the change map event is preceded by another event (e.g. a condition) it won't be triggered.

I will implement this later the day.

@Pyrdacor Pyrdacor self-assigned this Aug 18, 2020
@Pyrdacor Pyrdacor added the enhancement New feature or request label Aug 18, 2020
@Pyrdacor
Copy link
Owner

Pyrdacor commented Aug 18, 2020

Ok I implemented map event chains and improved map events in general. But then I noticed it wasn't the problem. The stairs are just marked as "block movement". The problem is that each tile can have a back and a front tile. And if it has a front tile, this tile matters in regards of movement blocking etc. But some tiles have the front tile not blocking but are actual walls in the game. Those tiles have a blocking back tile so I thought it is blocking if either front or back tile blocks. And so I did it that way. But the stairs are a case were this isn't working so I reverted the logic to "only front tile matters if present". Have to research this again.

In v1.0.10 (which is coming in a minute) this should work. But there will be some tiles that won't block anymore even if they should.
:(

@Thallyrion
Copy link
Author

In v1.0.10 (which is coming in a minute) this should work. But there will be some tiles that won't block anymore even if they should.

Indeed there are. I guess another way to determine the correct function of a tile has to be found.

blocking problem

@Thallyrion
Copy link
Author

Thallyrion commented Aug 18, 2020

Found another interesting case where the event still does not correctly work.

Tested with 1.10 House of Healers Cellar stairs still don't work. Thieves House first floor does work now.

house of healers cellar

@Pyrdacor
Copy link
Owner

Pyrdacor commented Aug 18, 2020

That's exactly the spot where I first saw that issue. There are not really bits left which could be the movement blocking flag. The only thing I can think of is a bit in the front tile data that says "get movement blocking from back tile". I will look into it the next days.

@Pyrdacor
Copy link
Owner

About the healer cellar: I will check tomorrow.

@Pyrdacor Pyrdacor added bug Something isn't working and removed enhancement New feature or request labels Aug 18, 2020
@Thallyrion
Copy link
Author

Found another spot for this issue. Southern City House

city house

@Pyrdacor
Copy link
Owner

Pyrdacor commented Aug 18, 2020

The new cases might be caused by map borders. I restricted to move the player only until a 1 tile border is reached in indoor maps as it wouldn't make sense to move him to the edge of a map. At least I thought so. But now as I see the doors and stairs on the edge of the map this might have been a mistake. So I think I know how to fix this.

@Pyrdacor
Copy link
Owner

Should be fixed in v1.0.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants