Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused Text : NPC Drongeb #42

Closed
a1exh opened this issue Jul 2, 2022 · 4 comments
Closed

Unused Text : NPC Drongeb #42

a1exh opened this issue Jul 2, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request fixed Fixed in upcoming release
Milestone

Comments

@a1exh
Copy link

a1exh commented Jul 2, 2022

The following string associated with character "Drongeb" seem to have no event trigger

"DOREB, THE LANDLORD OF DOR KIREDON, ACTUALLY SUCCEEDED IN BREWING AN ENJOYABLE TYPE OF ALE FROM THE PLANTS GROWING AROUND HERE. WHAT ELSE DO WE NEED?"

Possibly related to NPC_texts.amb 034.amb

"WE HAVE MANAGED TO BREW SOME REAL DWARF ALE FROM A FEW OF THE PLANTS HERE. THIS IS OUR FAMILY SECRET. TRY SOME!"

@Pyrdacor Pyrdacor self-assigned this Jul 2, 2022
@Pyrdacor Pyrdacor added the enhancement New feature or request label Jul 2, 2022
@Pyrdacor Pyrdacor added this to the Release 1.16 milestone Jul 2, 2022
@Pyrdacor
Copy link
Owner

Pyrdacor commented Jul 4, 2022

I investigated this and found that there is another text for Drongeb which can't be shown: "WELCOME! HOW NICE TO SEE YOU AGAIN!" This is text id 006 of NPC_texts.amb sub-file 059. It should be shown when talking to Drongeb for the second time. This is controlled via global var 67. But it isn't set. I will add it.

@Pyrdacor
Copy link
Owner

Pyrdacor commented Jul 4, 2022

From context the missing text should be displayed when you say the word "Beer" to Drongeb. This is present in the dictionary as index 33. But Drongeb has no events for that.

You can also say "Beer" to Doreb in Dor Kiredon. As you mentioned he will react with the last message you wrote.

I think it was planned this way:

You talk to Drongeb in Dor Grestin and he will eventually say that he misses the beer from Dor Kiredon. Then the keyword "Beer" is added to your dictionary. When you use it on Drongeb he will say the missing message to hint that Doreb knows more about it. Then you can use it in Dor Kiredon at Doreb. And he will react as well.

Maybe it was planned to add a "Beer" item that you can get this way. Doreb even says "Try some!" but there is no merchant or chest or even item to do so.

I will do the following:

  • Add the keyword when Drongeb talks about it.
  • Add a reaction event chain to Drongeb to trigger the text by this keyword.
  • Nothing to do for Doreb.

@Pyrdacor Pyrdacor added the fixed Fixed in upcoming release label Jul 4, 2022
@Pyrdacor
Copy link
Owner

Pyrdacor commented Jul 4, 2022

Done

@Pyrdacor
Copy link
Owner

Pyrdacor commented Jul 8, 2022

Should be fixed in 1.16

@Pyrdacor Pyrdacor closed this as completed Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed Fixed in upcoming release
Projects
None yet
Development

No branches or pull requests

2 participants