Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we drop Python 2 support? #158

Closed
eb8680 opened this issue Jul 13, 2019 · 3 comments
Closed

Should we drop Python 2 support? #158

eb8680 opened this issue Jul 13, 2019 · 3 comments

Comments

@eb8680
Copy link
Member

eb8680 commented Jul 13, 2019

Now that Pyro is dropping Python 2 support (pyro-ppl/pyro#1935), should we drop Python 2 in Funsor as well?

See Pyro checklist: pyro-ppl/pyro#1963

@eb8680 eb8680 added this to the Initial release milestone Jul 15, 2019
@fritzo
Copy link
Member

fritzo commented Jul 15, 2019

Yes. Unless you're in a hurry, I'd prefer to do this after we drop Python 2 support from Pyro, since we may learn things in doing that (e.g. like what to sed for).

@eb8680
Copy link
Member Author

eb8680 commented Jul 15, 2019

Unless you're in a hurry

No rush, since we haven't released yet. One potential reason to do this sooner is that we could start experimenting with adding Python 3 type annotations, but those may be unnecessary or may struggle with the amount of indirection in Funsor.

@eb8680
Copy link
Member Author

eb8680 commented Jul 25, 2019

Closing this as resolved by #172, reopen if necessary

@eb8680 eb8680 closed this as completed Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants