Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GramianTransform #243

Closed
fehiepsi opened this issue Jul 13, 2019 · 0 comments
Closed

Support GramianTransform #243

fehiepsi opened this issue Jul 13, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request low priority

Comments

@fehiepsi
Copy link
Member

fehiepsi commented Jul 13, 2019

This is a transform from A -> A @ A.T, which if

  • composed with LowerCholeskyTransform will create PositiveDefiniteTransform, which transforms a real vector to a positive definite matrix (though I am not interested in Wishart/Inverse-Wishart distributions, this transform will be helpful for other contributors who are interested in implementing those distributions)
  • composed with CorrCholeskyTransform will create CorrelationTransform, which transforms a real vector to a correlation matrix.

Then we can define LKJ distribution as TransformedDistribution(LKJCholesky, GramianTransform), so that users don't have to work with the scale tril version of a correlation matrix. It is better to for users see directly correlations of variables, rather than getting Cholesky and manually apply Grammian operator.

Inference will happen in LKJCholesky support when the approach to transformed distribution in #241 is available. Then it would be fast and not suffered from Cholesky numerical issue because no Cholesky operator is involved when computing log_prob terms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

1 participant