feat: add type hints for param_store.py in params module
#3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb8680
reviewed
Oct 26, 2022
pyro/params/param_store.py
Outdated
| @@ -4,10 +4,13 @@ | |||
| import re | |||
| import warnings | |||
| import weakref | |||
| from collections.abc import Iterator, KeysView | |||
There was a problem hiding this comment.
@willtai I think you need to replace collections.abc.Iterator with typing.Iterable for tests to pass
There was a problem hiding this comment.
thanks! However, I imported typing.Iterator rather than typing.Iterable
|
@willtai are you still working on this? Would it be okay if I take over this PR? |
|
Has anyone tried vscode's new copilot "brushes" feature to add type hints? I've bee having good luck just telling gpt-3.5-turbo to refactor my python code, and we may be able to automate much of this type hinting. |
|
Replaced by #3271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type hints to the
paramsmodule. This address this a section of this issue to add type hints.I intend to add more type hints wherever I can in future PRs.