Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed unlocked fields should allow null. #3787

Closed
bloveless opened this issue Jul 15, 2016 · 2 comments
Closed

Seed unlocked fields should allow null. #3787

bloveless opened this issue Jul 15, 2016 · 2 comments

Comments

@bloveless
Copy link
Member

When seeing an unlocked field I.E.

        'name'    => [
            'type'   => 'anomaly.field_type.text',
            'locked' => 0,
            'en'     => [
                'name'         => 'Name',
                'placeholder'  => '',
                'instructions' => '',
                'warning'      => ''
            ]

        ],

placeholder, instructions, and warning have to be an empty string or they will get a translation string rather than an empty string. This should work with null also.

@RyanThompson
Copy link
Member

Note to self: change tests to isset() instead of the null / ! value checks (migrations)

@RyanThompson
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants