New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PillarElement Class #162
Comments
A solution that came up to me would be to add another nested class to
In my opinion this would make sense, since a |
Regarding the PillarElement (and RingElement in the same manner) my main concerns are about computation speed. The current approach in https://github.com/pyroll-project/pyroll-pillar-model with array valued hooks is not as clean as it could be, but it is fast. The count of pillars has a very small impact on speed, whereas the count of disks has heavy impact due to the expensive unit and hook mechanics. |
I have moved all regarding the protocols to a new issue #163. Diskussion here only about the new elements. |
A seperate
PillarElement
class should be created to be able, to subdivideDiskElements
in width direction.This would of course make adjustments inside the PillarModel necessary. I'm pretty much up for suggestions about how this is useful and should be a part of the pyroll-core package.
The text was updated successfully, but these errors were encountered: