Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Too many package dependencies #15

Closed
kristjanvalur opened this issue Jan 20, 2021 · 1 comment · Fixed by #18
Closed

Too many package dependencies #15

kristjanvalur opened this issue Jan 20, 2021 · 1 comment · Fixed by #18
Labels
enhancement New feature or request

Comments

@kristjanvalur
Copy link

Hi there.
I just noticed when using your module that a lot of modules got pulled in.
In particular, the netifaces module is pulled in, which is a binary extension. And others.
Browsing your code, I can't see that there are other direct dependencies than fastapi and python-socketio. But the Pipfile includes a host of extensions, and so does setup.py. (python-engineio is automatically added as part of python-socketio)
Not sure why the module needs the various "extras" in setup.py, since there is no extras code.

@pyropy pyropy added the enhancement New feature or request label Jan 20, 2021
@pyropy
Copy link
Owner

pyropy commented Jan 20, 2021

Hey, thanks for addressing the issue. I'll try tidy up the dependencies file in next couple of days 🙏🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants