Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

fix: Improve thread safety and documentation in HeapProfiler and BlockProfiler #2

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix: Improve thread safety and documentation in HeapProfiler and BlockProfiler #2

merged 1 commit into from
Mar 30, 2023

Conversation

korniltsev
Copy link
Collaborator

  • Add sync.Mutex for thread-safe access to both profilers
  • Enhance documentation to describe stateful behavior, differences from pprof, and concurrent usage safety

@korniltsev
fix: Improve thread safety and documentation in HeapProfiler and Bloc…
bb34a5c 
…kProfiler

- Add sync.Mutex for thread-safe access to both profilers
- Enhance documentation to describe stateful behavior, differences from pprof, and concurrent usage safety
kolesnikovae
kolesnikovae approved these changes Mar 29, 2023
View reviewed changes
Copy link

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally makes sense – I guess this is especially handy in case if the profiler is exposed via an HTTP handler, when used in pull mode

@korniltsev korniltsev merged commit 0147166 into main Mar 30, 2023
@korniltsev korniltsev deleted the fix/sync branch August 4, 2023 05:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kolesnikovae kolesnikovae kolesnikovae approved these changes

@petethepig petethepig Awaiting requested review from petethepig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@korniltsev @kolesnikovae