Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve constant pool resolving speed #16

Merged
merged 3 commits into from
May 25, 2022

Conversation

korniltsev
Copy link
Collaborator

Do nothing in ResolveConstants if the class has already been resolved.

Before
BenchmarkParse-16 2 624531407 ns/op
After
BenchmarkParse-16 58 17558935 ns/op

Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@korniltsev korniltsev merged commit 3228ecf into main May 25, 2022
@korniltsev korniltsev deleted the fix/improve_constant_resolving_speed branch May 25, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants