Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: relay to phlare #21

Merged
merged 6 commits into from
Apr 23, 2023
Merged

feat: relay to phlare #21

merged 6 commits into from
Apr 23, 2023

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented Apr 20, 2023 •
edited

  • add PYROSCOPE_SCOPE_ORGID for phlare multitenancy
  • add PYROSCOPE_HTTP_HEADERS just in case
  • join ingestion path url so if the extension is configured with https://foo:4242/bar/ it will be ingested to https://foo:4242/bar/ingest
  • use basic auth from PYROSCOPE_REMOTE_ADDRESS
  • use basic auth from PYROSCOPE_BASIC_AUTH_USER PYROSCOPE_BASIC_AUTH_PASSWORD

@korniltsev korniltsev changed the title chore: replay to phlare chore: relay to phlare Apr 20, 2023
eh-am
eh-am approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@eh-am eh-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of a feat IMO, specially because otherwise release please will just ignore it.

@korniltsev korniltsev changed the title chore: relay to phlare feat: relay to phlare Apr 22, 2023
@korniltsev korniltsev merged commit bb9ac34 into main Apr 23, 2023
3 checks passed
@korniltsev korniltsev deleted the chore/phlare_relaying branch April 23, 2023 14:25
@pyroscopebot pyroscopebot mentioned this pull request Apr 23, 2023
Merged
@Rperry2174 Rperry2174 mentioned this pull request Apr 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eh-am eh-am eh-am approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@korniltsev @eh-am