-
Notifications
You must be signed in to change notification settings - Fork 572
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: support importing adhoc profiles in pprof or collapsed formats (#…
…649) * chore: move sample type config from server to tree. In the tree package it can be more easily reused wherever it's needed. * feat: support importing adhoc profiles in pprof or collapsed formats * apply linter suggestions. * Avoid an extra copy encoding the profile directly to the response.
- Loading branch information
Showing
5 changed files
with
177 additions
and
75 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| package server | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "encoding/json" | ||
| "errors" | ||
| "fmt" | ||
| "strconv" | ||
| "time" | ||
|
|
||
| "github.com/pyroscope-io/pyroscope/pkg/agent/spy" | ||
| "github.com/pyroscope-io/pyroscope/pkg/convert" | ||
| "github.com/pyroscope-io/pyroscope/pkg/storage" | ||
| "github.com/pyroscope-io/pyroscope/pkg/storage/tree" | ||
| "github.com/pyroscope-io/pyroscope/pkg/structs/flamebearer" | ||
| ) | ||
|
|
||
| func jsonToProfile(b []byte, _ string, _ int) (*flamebearer.FlamebearerProfile, error) { | ||
| var profile flamebearer.FlamebearerProfile | ||
| if err := json.Unmarshal(b, &profile); err != nil { | ||
| return nil, fmt.Errorf("unable to unmarshall JSON: %w", err) | ||
| } | ||
| return &profile, nil | ||
| } | ||
|
|
||
| func pprofToProfile(b []byte, name string, maxNodes int) (*flamebearer.FlamebearerProfile, error) { | ||
| p, err := convert.ParsePprof(bytes.NewReader(b)) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("parsing pprof: %w", err) | ||
| } | ||
| // TODO(abeaumont): Support multiple sample types | ||
| for _, stype := range p.SampleTypes() { | ||
| sampleRate := uint32(100) | ||
| units := "samples" | ||
| if c, ok := tree.DefaultSampleTypeMapping[stype]; ok { | ||
| units = c.Units | ||
| if c.Sampled && p.Period > 0 { | ||
| sampleRate = uint32(time.Second / time.Duration(p.Period)) | ||
| } | ||
| } | ||
| t := tree.New() | ||
| p.Get(stype, func(_labels *spy.Labels, name []byte, val int) { | ||
| t.Insert(name, uint64(val)) | ||
| }) | ||
|
|
||
| out := &storage.GetOutput{ | ||
| Tree: t, | ||
| Units: units, | ||
| SpyName: name, | ||
| SampleRate: sampleRate, | ||
| } | ||
| profile := flamebearer.NewProfile(out, maxNodes) | ||
| return &profile, nil | ||
| } | ||
| return nil, errors.New("no supported sample type found") | ||
| } | ||
|
|
||
| func collapsedToProfile(b []byte, name string, maxNodes int) (*flamebearer.FlamebearerProfile, error) { | ||
| t := tree.New() | ||
| for _, line := range bytes.Split(b, []byte("\n")) { | ||
| if len(line) == 0 { | ||
| continue | ||
| } | ||
| i := bytes.LastIndexByte(line, ' ') | ||
| if i < 0 { | ||
| return nil, errors.New("unable to find stacktrace and value separator") | ||
| } | ||
| value, err := strconv.ParseUint(string(line[i+1:]), 10, 64) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("unable to parse sample value: %w", err) | ||
| } | ||
| t.Insert(line[:i], value) | ||
| } | ||
| out := &storage.GetOutput{ | ||
| Tree: t, | ||
| SpyName: name, | ||
| SampleRate: 100, // We don't have this information, use the default | ||
| } | ||
| profile := flamebearer.NewProfile(out, maxNodes) | ||
| return &profile, nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters