Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): hide timeline tooltip if there's no data #1472

Merged
merged 1 commit into from Sep 8, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Sep 7, 2022

Initially raised #1469 (comment)

We always render a tooltip, even if there's no body:
image

It's a bit tricky to solve this, since it would require the parent to know whether the children is empty. Instead of manually rendering I decided to just use CSS to hide the tooltip if it's empty (ie its children is null).

@eh-am eh-am changed the title fix(webapp): hide tooltip if there's no data fix(webapp): hide timeline tooltip if there's no data Sep 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 420.48 KB (0%) 8.5 s (0%) 3.2 s (-15.53% 🔽) 11.7 s
webapp/public/assets/app.css 15.68 KB (+0.04% 🔺) 314 ms (+0.04% 🔺) 0 ms (+100% 🔺) 314 ms
webapp/public/assets/styles.css 9.47 KB (0%) 190 ms (0%) 0 ms (+100% 🔺) 190 ms
packages/pyroscope-flamegraph/dist/index.js 91.8 KB (0%) 1.9 s (0%) 1.6 s (+55.58% 🔺) 3.5 s
packages/pyroscope-flamegraph/dist/index.node.js 91.65 KB (0%) 1.9 s (0%) 635 ms (-13.44% 🔽) 2.5 s
packages/pyroscope-flamegraph/dist/index.css 7.12 KB (0%) 143 ms (0%) 0 ms (+100% 🔺) 143 ms

@eh-am eh-am marked this pull request as ready for review September 7, 2022 15:14
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #1472 (2d82199) into main (c0d4152) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1472   +/-   ##
=======================================
  Coverage   68.66%   68.66%           
=======================================
  Files         131      131           
  Lines        4316     4316           
  Branches     1166     1166           
=======================================
  Hits         2963     2963           
  Misses       1347     1347           
  Partials        6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@pavelpashkovsky pavelpashkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eh-am eh-am merged commit df4c8cc into main Sep 8, 2022
@eh-am eh-am deleted the fix/hide-tooltip-when-theres-no-data branch September 8, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants