Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #168 - Implement data retention in storage layer (WIP) #182

Merged
merged 27 commits into from
Jun 17, 2021
Merged

Closes #168 - Implement data retention in storage layer (WIP) #182

merged 27 commits into from
Jun 17, 2021

Conversation

s4kibs4mi
Copy link
Contributor

Data is important but how long? With this implementation, you can decide how much old data you want to keep and which you want to be removed.

@s4kibs4mi s4kibs4mi self-assigned this May 9, 2021
@s4kibs4mi s4kibs4mi changed the title Closes #168 - Implement data retention in storage layer Closes #168 - Implement data retention in storage layer (WIP) May 9, 2021
@s4kibs4mi s4kibs4mi added backend Mostly go code storage Low level storage matters labels May 9, 2021
@s4kibs4mi s4kibs4mi linked an issue May 9, 2021 that may be closed by this pull request
Implement data retention in storage layer #168
Closed
6 tasks
@codecov
Copy link

codecov bot commented May 9, 2021 •
edited

Codecov Report

Merging #182 (b2060e3) into main (c1babda) will decrease coverage by 0.81%.
The diff coverage is 52.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   55.65%   54.85%   -0.80%     
==========================================
  Files          82       86       +4     
  Lines        3249     3583     +334     
==========================================
+ Hits         1808     1965     +157     
- Misses       1259     1414     +155     
- Partials      182      204      +22
Impacted Files Coverage Δ
pkg/agent/selfprofile.go 0.00% <0.00%> (ø)
pkg/agent/upstream/direct/direct.go 0.00% <0.00%> (ø)
pkg/cli/cli.go 61.25% <0.00%> (ø)
pkg/cli/server_unix.go 0.00% <0.00%> (ø)
pkg/cli/usage.go 9.76% <0.00%> (-0.50%) ⬇️
pkg/server/ingest.go 56.80% <0.00%> (-3.73%) ⬇️
pkg/storage/key.go 90.33% <ø> (+1.44%) ⬆️
pkg/storage/local.go 0.00% <0.00%> (ø)
pkg/storage/segment/relationship.go 100.00% <ø> (ø)
pkg/util/attime/attime.go 100.00% <ø> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351586d...b2060e3. Read the comment docs.

petethepig
petethepig reviewed May 13, 2021
View reviewed changes
pkg/cli/cli.go Outdated Show resolved Hide resolved
petethepig
petethepig reviewed May 13, 2021
View reviewed changes
pkg/storage/storage.go Outdated Show resolved Hide resolved
petethepig
petethepig reviewed May 13, 2021
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
@s4kibs4mi s4kibs4mi requested a review from petethepig May 16, 2021 20:22
@petethepig petethepig added this to In progress in Pyroscope Public Roadmap May 17, 2021
petethepig
petethepig reviewed May 18, 2021
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
@s4kibs4mi s4kibs4mi requested a review from petethepig May 20, 2021 09:16
@Rperry2174 Rperry2174 moved this from In progress to In Review in Pyroscope Public Roadmap May 21, 2021
@petethepig petethepig merged commit af9a745 into main Jun 17, 2021
@petethepig petethepig deleted the feature/data-retention-in-storage-layer branch June 17, 2021 08:08
@Rperry2174 Rperry2174 moved this from Included in Next Release to Done in Pyroscope Public Roadmap Aug 3, 2021
@tuananh2508
Copy link

Does this feature has document yet ? Cause I can't find this feature on https://pyroscope.io/docs/ @petethepig

@tuananh2508 tuananh2508 mentioned this pull request Sep 18, 2021
Closed
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
@cyriltovena
Merge pull request #182 from grafana/page-info
858ca87 
Adds Pages informations to parquet-tool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petethepig petethepig petethepig approved these changes

@Rperry2174 Rperry2174 Awaiting requested review from Rperry2174

Assignees

@s4kibs4mi s4kibs4mi

Labels
backend Mostly go code storage Low level storage matters
Projects
Pyroscope Public Roadmap
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement data retention in storage layer
3 participants
@s4kibs4mi @tuananh2508 @petethepig