Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue#163: nil reference when paring the tries #194

Merged
merged 1 commit into from
May 18, 2021

Conversation

alonlong
Copy link
Contributor

add the error handler for paring the tries

@alonlong alonlong added the bug Something isn't working label May 18, 2021
@alonlong alonlong requested a review from petethepig May 18, 2021 00:02
@github-actions github-actions bot requested a review from Rperry2174 May 18, 2021 00:03
Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this @alonlong . This closes #163

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #194 (bce5f83) into main (555f765) will increase coverage by 0.06%.
The diff coverage is 33.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   57.29%   57.35%   +0.06%     
==========================================
  Files          73       73              
  Lines        2938     2942       +4     
==========================================
+ Hits         1683     1687       +4     
+ Misses       1112     1110       -2     
- Partials      143      145       +2     
Impacted Files Coverage Δ
pkg/convert/parser.go 62.80% <33.34%> (-3.06%) ⬇️
pkg/server/ingest.go 63.39% <33.34%> (-1.83%) ⬇️
pkg/agent/session.go 67.22% <0.00%> (+3.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555f765...bce5f83. Read the comment docs.

@petethepig petethepig merged commit fc9e25b into main May 18, 2021
@petethepig petethepig deleted the hotfix/nil_reference_#163 branch May 18, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants