Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes: #192 Use the specific config structure for each command #208

Merged
merged 5 commits into from
May 25, 2021
Merged

Closes: #192 Use the specific config structure for each command #208

merged 5 commits into from
May 25, 2021

Conversation

AdrK
Copy link
Contributor

@AdrK AdrK commented May 22, 2021 •
edited

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AdrK AdrK changed the title config.Server done Closes: #192 Use the specific config structure for each command May 22, 2021
@AdrK AdrK linked an issue May 22, 2021 that may be closed by this pull request
Use the specific config structure for each command #192
Closed
@codecov
Copy link

codecov bot commented May 22, 2021 •
edited

Codecov Report

Merging #208 (60ba7e0) into main (5098f57) will decrease coverage by 0.33%.
The diff coverage is 36.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   57.36%   57.03%   -0.32%     
==========================================
  Files          73       73              
  Lines        2943     2981      +38     
==========================================
+ Hits         1688     1700      +12     
- Misses       1110     1131      +21     
- Partials      145      150       +5
Impacted Files Coverage Δ
pkg/agent/profiler/profiler.go 0.00% <0.00%> (ø)
pkg/agent/selfprofile.go 0.00% <0.00%> (ø)
pkg/agent/spy/spy.go 5.00% <0.00%> (ø)
pkg/agent/upstream/direct/direct.go 0.00% <ø> (ø)
pkg/analytics/analytics.go 84.06% <ø> (ø)
pkg/convert/cli.go 0.00% <0.00%> (ø)
pkg/server/render.go 0.00% <0.00%> (ø)
pkg/storage/labels/labels.go 0.00% <ø> (ø)
pkg/storage/segment/segment.go 89.26% <ø> (ø)
pkg/storage/tree/flamebearer.go 100.00% <ø> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec9540...60ba7e0. Read the comment docs.

@AdrK AdrK marked this pull request as draft May 22, 2021 08:30
@AdrK AdrK force-pushed the 192_Use_the_specific_config_structure_for_each_command branch 2 times, most recently from 639bd31 to 9ad208d Compare May 22, 2021 09:35
@AdrK AdrK force-pushed the 192_Use_the_specific_config_structure_for_each_command branch from 9ad208d to 91ba7fe Compare May 22, 2021 09:39
AdrK
AdrK commented May 22, 2021
View reviewed changes
pkg/agent/cli/agent.go
cs *csock.CSock
activeProfiles map[int]*agent.ProfileSession
id id.ID
u upstream.Upstream
}

func New(cfg *config.Config) *Agent {
func New(cfg *config.Agent) *Agent {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petethepig Seems that this is unused, is that possible?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we'll delete it soon

@AdrK AdrK marked this pull request as ready for review May 24, 2021 06:34
AdrK
AdrK commented May 24, 2021
View reviewed changes
pkg/agent/cli/agent.go
@@ -15,19 +15,19 @@ import (
)

type Agent struct {
cfg *config.Config
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petethepig
Do we want to keep the config.Config struct?
If my understanding is correct, the lifetime of all the config structs are withing the Start(cfg *config.Config) function in cli.go, so maybe we don't need an extra container for all the configs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good point, we might do that in the future

@petethepig petethepig merged commit 2f33d66 into main May 25, 2021
@petethepig petethepig deleted the 192_Use_the_specific_config_structure_for_each_command branch May 25, 2021 22:17
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
@cyriltovena
Merge pull request #208 from grafana/order-series-alphabetical
c5e7b3c 
Sort Profiles by Labels (alphabetical) in Parquet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petethepig petethepig Awaiting requested review from petethepig

@Rperry2174 Rperry2174 Awaiting requested review from Rperry2174

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the specific config structure for each command
4 participants
@AdrK @CLAassistant @petethepig @AdrianKurylak