-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support (agent) #212
Conversation
Codecov Report
@@ Coverage Diff @@
## main #212 +/- ##
==========================================
- Coverage 56.07% 55.45% -0.62%
==========================================
Files 74 82 +8
Lines 3089 3214 +125
==========================================
+ Hits 1732 1782 +50
- Misses 1186 1252 +66
- Partials 171 180 +9
Continue to review full report at Codecov.
|
@@ -1,3 +1,5 @@ | |||
// +build !windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FreeSpace
on Linux/macOS relies on statfs bfree (free blocks in filesystem), consider use of bavail (free blocks available to unprivileged user).
# Conflicts: # pkg/exec/cli.go
1406991
to
a770d0d
Compare
a770d0d
to
7985b67
Compare
7985b67
to
64ba0bb
Compare
3f71e68
to
353853a
Compare
7db5ff1
to
39eb6e7
Compare
# Conflicts: # go.mod # go.sum # pkg/cli/cli.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Use correct column name for sorting order
This PR is the first step toward full-fledged Windows support. With this change, pyroscope can be run on Windows in
agent
,exec
andconnect
modes.Limitations:
gospy
anddotnetspy
can be used. In contrast to Linux/macOS, on Windows,dotnetspy
accounts time spent in unmanaged code.