handle error when starting the server #215

alonlong · 2021-05-25T16:00:01Z

handle error when starting the server, remove the panic
make the logger always available, remove the nil check
optimize some logics for remote uploading profile

codecov · 2021-05-25T16:06:38Z

Codecov Report

Merging #215 (8620538) into main (73a7aad) will decrease coverage by 0.26%.
The diff coverage is 43.68%.

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   57.03%   56.78%   -0.25%     
==========================================
  Files          73       73              
  Lines        2988     2991       +3     
==========================================
- Hits         1704     1698       -6     
- Misses       1133     1140       +7     
- Partials      151      153       +2

Impacted Files	Coverage Δ
pkg/agent/profiler/profiler.go	`0.00% <0.00%> (ø)`
pkg/agent/selfprofile.go	`0.00% <0.00%> (ø)`
pkg/cli/cli.go	`54.45% <0.00%> (-0.40%)`	⬇️
pkg/agent/upstream/remote/remote.go	`65.63% <62.50%> (+0.84%)`	⬆️
pkg/exec/cli.go	`39.78% <62.50%> (-0.65%)`	⬇️
pkg/server/controller.go	`40.96% <63.64%> (-0.04%)`	⬇️
pkg/agent/session.go	`64.00% <100.00%> (-2.12%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a7aad...8620538. Read the comment docs.

petethepig · 2021-05-26T00:18:45Z

pkg/agent/upstream/remote/remote.go

-		u.done <- &wg
+func (r *Remote) Stop() {
+	if r.done != nil {
+		close(r.done)


I like this solution 👍

Change format to nested set for the dataframe

handle error when starting the server

679ee1e

alonlong added enhancement New feature or request backend Mostly go code labels May 25, 2021

alonlong requested a review from petethepig May 25, 2021 16:00

alonlong assigned petethepig May 25, 2021

github-actions bot requested a review from Rperry2174 May 25, 2021 16:00

petethepig added 2 commits May 25, 2021 16:45

Merge branch 'main' into feature/error_handler_for_start_server

699686c

post merge fixes

8620538

petethepig reviewed May 26, 2021

View reviewed changes

petethepig merged commit 970e706 into main May 26, 2021

petethepig deleted the feature/error_handler_for_start_server branch May 26, 2021 00:24

korniltsev pushed a commit that referenced this pull request Jul 18, 2023

Change dataframe format to nested set #215

ed195eb

Change format to nested set for the dataframe

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

handle error when starting the server #215

handle error when starting the server #215

alonlong commented May 25, 2021

codecov bot commented May 25, 2021 •

edited

petethepig May 26, 2021

handle error when starting the server #215

handle error when starting the server #215

Conversation

alonlong commented May 25, 2021

codecov bot commented May 25, 2021 • edited

Codecov Report

petethepig May 26, 2021

Choose a reason for hiding this comment

codecov bot commented May 25, 2021 •

edited