Graceful shutdown #243
Merged
Graceful shutdown #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `exec` exit code is now preserved. * Improved process check for `connect`. * Relay signals to child process in `exec`.
kolesnikovae
added
enhancement
# Conflicts: # pkg/cli/server_unix.go # pkg/server/controller.go # pkg/storage/local.go # pkg/storage/storage.go # pkg/util/atexit/atexit.go
kolesnikovae
requested review from
alonlong and
petethepig
and removed request for
alonlong
Codecov Report
@@ Coverage Diff @@
## main #243 +/- ##
==========================================
- Coverage 54.64% 54.12% -0.51%
==========================================
Files 86 87 +1
Lines 3606 3631 +25
==========================================
- Hits 1970 1965 -5
- Misses 1431 1467 +36
+ Partials 205 199 -6
Continue to review full report at Codecov.
|
petethepig
reviewed
Jun 22, 2021
| // Normally, if the program ran, the call should return ExitError and | ||
| // the exit code must be preserved. Otherwise, the error originates from | ||
| // pyroscope and will be printed. | ||
| if e, ok := err.(*goexec.ExitError); ok { |
petethepig
approved these changes
Jun 22, 2021
petethepig
reviewed
Jun 22, 2021
| } | ||
|
|
||
| func (svc *serverService) Start() error { | ||
| g, ctx := errgroup.WithContext(context.Background()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is aimed to improve pyroscope shutdown and initialisation.
controller(http server) is drained at the very beginning of the shutdown to prevent storage reads and writes. Diagnostic endpoints (healthz, metrics, pprof) are handled till the storage closes, thus allowing clean exit.IsClosingcheck fromstorage: it is guaranteed that no calls to storage will be made afterClose.atexitpackage was removed.