-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed wrong time calc in dotnetspy. #252
Conversation
@@ -89,7 +89,7 @@ func (s *session) start() error { | |||
for k, v := range p.Samples() { | |||
s.ch <- line{ | |||
name: []byte(k), | |||
val: int(v.Milliseconds()) / 10, | |||
val: int(v.Milliseconds()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples/dotnet/web
was not working and I found that this is due to wrong calculations here.
I wonder why we were doing /10
? For v.Milliseconds() == 1
, this was resolving to 0
and no samples were reported in stacktrace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a leftover. Thank you for fixing this!
LGTM. I've also updated |
@kolesnikovae So that must mean we should be seeing more data now when we profile dotnet apps, right? |
Codecov Report
@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 54.18% 54.20% +0.03%
==========================================
Files 87 87
Lines 3631 3631
==========================================
+ Hits 1967 1968 +1
+ Misses 1465 1464 -1
Partials 199 199
Continue to review full report at Codecov.
|
My bad, this denominator is not a mistake - #255:
Thus, we cannot capture samples of duration less than @AdrK, the reason why |
Reexport values from helm into a JSON file
No description provided.