-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profiling python web frameworks #428
Comments
Hi @raqib-hayder Thanks for the kind words :) Pyroscope should work great with the use-case you're describing and should generally work with any framework like This might be related to the way subprocesses / forks are treated by the pyroscope agent. I can try to reproduce the issue with the docker image you linked and see if there's a bug somewhere. The only question I have right now is how are you integrating with pyroscope? Are you running it via |
@petethepig : We are using the pip package |
@Rperry2174 and @petethepig : Thank you for updating the example. Will give this a try and let you guys know how it went. Much apprecaited. |
@raqib-hayder I created an example with fastapi and was able to reproduce not being able to see the stacktraces for the starlette middleware. We're still looking into why these don't show up in this particular case |
You guys are awesome! Thank you for promptly looking into this. |
Hi @raqib-hayder We just released a new version of the pip package (0.4.0) with a fix for this issue. Let me know if it works for you. |
Hey @petethepig: It does. Thank you! |
Amazing work with Pyroscope. 馃憦馃徑
Is there a way to profile web frameworks like FastAPI, Starlette or Flask?
We are currently using new relic and were testing out Pyroscope as an alternative for performance monitoring. We are using
gunicorn
withUvicornWorkers
andFastAPI
as our framework using the following docker image.We are able to see all
gunicorn
,uvicorn
and our application function calls but unable to see anything related to Starlette (the framework FastAPI is wrapped around), specifically Starlette middleware calls.I feel like I am missing something silly here, any help would be appreciated.
Thank you 馃槃
The text was updated successfully, but these errors were encountered: