Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E test #446

Merged
merged 3 commits into from
Oct 8, 2021
Merged

E2E test #446

merged 3 commits into from
Oct 8, 2021

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Oct 7, 2021

Nothing much here, just adding very basic e2e tests to validate the client is consuming what the server is sending.

That will give us confidence when updating the server (well, at least the endpoints that are called by the / /comparison and /comparison-diff pages)

cypress/integration/e2e.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #446 (87ffa9a) into main (29781f8) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   51.64%   51.67%   +0.04%     
==========================================
  Files         125      125              
  Lines        5719     5719              
==========================================
+ Hits         2953     2955       +2     
+ Misses       2479     2477       -2     
  Partials      287      287              
Impacted Files Coverage Δ
pkg/agent/upstream/remote/remote.go 66.18% <0.00%> (+2.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29781f8...87ffa9a. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Oct 7, 2021

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 164.30 164.53 0.22 (0.13%) 5%
total items processed 129463.00 129891.00 428.00 (0.33%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against 2d5292c

Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petethepig petethepig merged commit 2fd51d1 into main Oct 8, 2021
@petethepig petethepig deleted the e2e-test branch October 8, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants