Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanup and fixes #453

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Small cleanup and fixes #453

merged 1 commit into from
Oct 11, 2021

Conversation

proggga
Copy link
Contributor

@proggga proggga commented Oct 8, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @proggga! LGTM.

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #453 (81eed83) into main (bac1171) will increase coverage by 0.07%.
The diff coverage is 41.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
+ Coverage   51.51%   51.57%   +0.07%     
==========================================
  Files         125      125              
  Lines        5683     5734      +51     
==========================================
+ Hits         2927     2957      +30     
- Misses       2472     2488      +16     
- Partials      284      289       +5     
Impacted Files Coverage Δ
pkg/storage/dimension/serialization.go 0.00% <0.00%> (ø)
pkg/storage/dict/serialize.go 58.70% <33.34%> (-2.66%) ⬇️
pkg/storage/dict/dict.go 75.76% <70.00%> (ø)
pkg/flameql/flameql.go 87.88% <100.00%> (ø)
pkg/storage/tree/tree.go 82.66% <100.00%> (+0.18%) ⬆️
pkg/server/handler.go 18.13% <0.00%> (-0.34%) ⬇️
pkg/agent/profiler/profiler.go 0.00% <0.00%> (ø)
pkg/analytics/analytics.go 87.02% <0.00%> (+0.53%) ⬆️
pkg/server/render.go 67.47% <0.00%> (+2.77%) ⬆️
pkg/agent/session.go 63.91% <0.00%> (+5.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac1171...81eed83. Read the comment docs.

Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @proggga. Congrats on your first Pyroscope PR!

@petethepig petethepig merged commit ec5b5fa into grafana:main Oct 11, 2021
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
feat(agent/sd): add support HTTP service discovery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants