Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate size-limit into its own workflow #465

Merged
merged 3 commits into from
Oct 13, 2021
Merged

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Oct 13, 2021

the previous workflow (js-tests) was run in main merges as well
which doesn't make sense, since this action is targetted to PRs

the previous workflow (js-tests) was run in main merges as well
which doesn't make sense, since this action is targetted to PRs
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 439.22 KB (0%) 8.8 s (0%) 332 ms (-72.99% 🔽) 9.2 s

@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Oct 13, 2021

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 135.65 135.40 -0.24 (-0.18%) 5%
total items processed 112674.00 112965.00 291.00 (0.26%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against 1fe7dd5

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #465 (df97dcc) into main (56c519d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #465   +/-   ##
=======================================
  Coverage   51.57%   51.57%           
=======================================
  Files         125      125           
  Lines        5734     5734           
=======================================
  Hits         2957     2957           
  Misses       2488     2488           
  Partials      289      289           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c519d...df97dcc. Read the comment docs.

@eh-am eh-am merged commit 224ac5c into main Oct 13, 2021
@eh-am eh-am deleted the size-limit-on-pr branch October 13, 2021 15:34
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Fixes the scrape timeout validation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants