Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dotnetspy for macos build #469

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Enable dotnetspy for macos build #469

merged 1 commit into from
Oct 18, 2021

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented Oct 18, 2021

Currently, dotnetspy is only enabled on linux and windows, although there are no OS-specific dependencies. This PR enables dotnetspy for macos.

@kolesnikovae kolesnikovae self-assigned this Oct 18, 2021
@kolesnikovae kolesnikovae added .net dotnet 🍎 macos Related to macOS bug Something isn't working and removed .net labels Oct 18, 2021
@kolesnikovae kolesnikovae changed the title fix: enable dotnetspy for macos build Enable dotnetspy for macos build Oct 18, 2021
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 439.67 KB (0%) 8.8 s (0%) 1.1 s (+1.78% 🔺) 9.9 s

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #469 (eda5299) into main (bc427f2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #469   +/-   ##
=======================================
  Coverage   51.73%   51.73%           
=======================================
  Files         144      144           
  Lines        6262     6262           
  Branches       93       93           
=======================================
  Hits         3239     3239           
  Misses       2707     2707           
  Partials      316      316           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b43d96a...eda5299. Read the comment docs.

@kolesnikovae kolesnikovae marked this pull request as ready for review October 18, 2021 07:20
Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this so promtly

@petethepig petethepig merged commit c155ddc into main Oct 18, 2021
@petethepig petethepig deleted the dotnet_macos branch October 18, 2021 07:27
@pyroscopebot
Copy link
Collaborator

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 125.76 125.08 -0.69 (-0.55%) 5%
total items processed 119115.00 118681.00 -434.00 (-0.37%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against 04251f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dotnet 🍎 macos Related to macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants