Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the correct controller variable. #615

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Conversation

abeaumont
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 316.83 KB (0%) 6.4 s (0%) 786 ms (+7.52% 🔺) 7.2 s

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #615 (d8e59de) into main (1533b5c) will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
+ Coverage   76.28%   76.49%   +0.22%     
==========================================
  Files          43       43              
  Lines        1454     1450       -4     
  Branches      284      283       -1     
==========================================
  Hits         1109     1109              
+ Misses        313      310       -3     
+ Partials       32       31       -1     
Impacted Files Coverage Δ
webapp/javascript/redux/actions.js 19.87% <ø> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1533b5c...d8e59de. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Dec 16, 2021

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 158.46 158.42 -0.04 (-0.02%) 5%
total items processed 113096.00 112783.00 -313.00 (-0.28%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against f3171d4

Copy link
Collaborator

@eh-am eh-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch but I don't think this is even being called 🤔

@abeaumont
Copy link
Contributor Author

Yeah, you are right, it's not, let's do some clean-up then.

@petethepig petethepig merged commit ccd97f9 into main Dec 22, 2021
@petethepig petethepig deleted the fix/abort-fetch-names branch December 22, 2021 03:21
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
* Update golang version to 1.19.8

* Add script to update go versions

* Remove build matrix

We no longer use to build other versions or OSes. This avoids having to
change the required CI checks for protected branches on every go
release.

* Remove accidental curly braces that prevent caching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants