Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): new tags dropdown #642

Merged
merged 7 commits into from
Dec 22, 2021
Merged

feat(frontend): new tags dropdown #642

merged 7 commits into from
Dec 22, 2021

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Dec 22, 2021

Related to #618

  • Use @ui/Dropdown component (which uses szhsin/react-menu under the hood)
  • Add a scrollbar for when tags don't fit on the screen
  • Add search bar for each tag
Peek.2021-12-22.14-36.mp4

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 291.92 KB (+0.11% 🔺) 5.9 s (+0.11% 🔺) 328 ms (+90.67% 🔺) 6.2 s

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #642 (8e497d5) into main (ee52a68) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #642   +/-   ##
=======================================
  Coverage   75.76%   75.76%           
=======================================
  Files          45       45           
  Lines        1588     1588           
  Branches      292      292           
=======================================
  Hits         1203     1203           
  Misses        356      356           
  Partials       29       29           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee52a68...8e497d5. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 147.00 146.97 -0.02 (-0.02%) 5%
total items processed 122839.00 122785.00 -54.00 (-0.04%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against 379b273

@petethepig petethepig changed the title Feat/tags dropdown feat(frontend): new tags dropdown Dec 22, 2021
@petethepig petethepig merged commit 6290e45 into main Dec 22, 2021
@petethepig petethepig deleted the feat/tags-dropdown branch December 22, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants