Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support importing adhoc profiles in pprof or collapsed formats #649

Merged
merged 5 commits into from
Jan 3, 2022

Conversation

abeaumont
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 274.33 KB (0%) 5.5 s (0%) 263 ms (+28.38% 🔺) 5.8 s

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #649 (ea3ccf3) into main (923fde6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #649   +/-   ##
=======================================
  Coverage   75.70%   75.70%           
=======================================
  Files          45       45           
  Lines        1592     1592           
  Branches      294      294           
=======================================
  Hits         1205     1205           
  Misses        358      358           
  Partials       29       29           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 923fde6...ea3ccf3. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Dec 23, 2021

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 151.53 151.72 0.19 (0.12%) 5%
total items processed 115831.00 116168.00 337.00 (0.29%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against dbb17d7

Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @abeaumont I didn't know how to resolve the conflict, but I'll merge once you resolve it.

@petethepig petethepig merged commit 14ee845 into main Jan 3, 2022
@petethepig petethepig deleted the feat/adhoc-import-formats branch January 3, 2022 22:47
kolesnikovae pushed a commit that referenced this pull request Jan 7, 2022
…649)

* chore: move sample type config from server to tree.

In the tree package it can be more easily reused wherever it's needed.

* feat: support importing adhoc profiles in pprof or collapsed formats

* apply linter suggestions.

* Avoid an extra copy encoding the profile directly to the response.
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
* Make both `/ui/?query=` and `/ui?query=` work

* Add redirection

* Address comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants