Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): don't allow selecting empty apps #723

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Jan 13, 2022

Due to circumstances, some of our old apps have empty strings as name. This PR ashamedly skips those when fetching from the backend.

Highlighted an app with empty name (which this PR skips)
image

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 341.51 KB (+0.01% 🔺) 6.9 s (+0.01% 🔺) 1.1 s (+1.4% 🔺) 7.9 s

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #723 (743b189) into main (fff5af0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
+ Coverage   76.61%   76.63%   +0.03%     
==========================================
  Files          60       60              
  Lines        2069     2071       +2     
  Branches      371      432      +61     
==========================================
+ Hits         1585     1587       +2     
  Misses        456      456              
  Partials       28       28              
Impacted Files Coverage Δ
webapp/javascript/services/appNames.ts 90.48% <100.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7949d56...743b189. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Result

main pr diff threshold
throughput 222.56 227.89 5.33 (2.37%) 5%
total items processed 67376.00 68665.00 1289.00 (1.90%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope-main:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope-main:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}

Generated by 🚫 dangerJS against f9d588a

Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🎉

@Rperry2174 Rperry2174 merged commit 2378ab5 into main Jan 13, 2022
@Rperry2174 Rperry2174 deleted the fix/hide-empty-app branch January 13, 2022 20:50
juliosaraiva pushed a commit to juliosaraiva/pyroscope that referenced this pull request Jan 16, 2022
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants