improve: fix unsafeStrToSlice panic due to empty string #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #772 +/- ##
=======================================
Coverage 73.03% 73.03%
=======================================
Files 65 65
Lines 2291 2291
Branches 493 493
=======================================
Hits 1673 1673
Misses 579 579
Partials 39 39 Continue to review full report at Codecov.
|
abeaumont
added a commit
that referenced
this pull request
Jan 28, 2022
This is a different approach to PR #772. Instead of filtering out empty strings in one of the possible insertion paths, we handle it properly to prevent problems both from this or other insertion paths: - We remove the unsafe string to bytes conversion, using instead the insertion functions that handle strings. - We handle the corner case of empty strings properly to prevent an infinite loop.
There was a problem hiding this comment.
Thank you for fixing the issue @linthan!
I’m wondering if this is a hypothetic case or we do have traces with empty function/frame names. That would mean we should make sure such a profile is handled correctly along the whole workflow (ingest/query).
kolesnikovae
approved these changes
Jan 28, 2022
korniltsev
pushed a commit
that referenced
this pull request
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to empty string, the unsafeStrToSlice will result in the panic of the pyroscope server.