Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): add package coloring for rust #798

Merged
merged 10 commits into from Feb 7, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Feb 4, 2022

Closes #789

This PR contains 2 parts:

Some prep work, adding tests for existing coloring integrations

Couldn't add much tests for phpspy since our example is too simple.
Plus simplified the default one, since it seems to use go scheme by default.

Supports rust

For that the regex used is to just get whatever is before the first ::.

It's a bit naive, since it doesn't deal with cases such as

<core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll

That @omarabid said it should be treated as core::future::future::Future::poll.

But should be a good start.

image

@eh-am eh-am changed the title chore(frontend): test existing package coloring chore(frontend): test existing package name extraction from stacktrace Feb 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 353.74 KB (-0.02% 🔽) 7.1 s (-0.02% 🔽) 1.3 s (+3.37% 🔺) 8.4 s

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #798 (380749f) into main (bee6483) will increase coverage by 0.04%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
+ Coverage   73.09%   73.12%   +0.04%     
==========================================
  Files          65       65              
  Lines        2311     2310       -1     
  Branches      421      421              
==========================================
  Hits         1689     1689              
+ Misses        594      593       -1     
  Partials       28       28              
Impacted Files Coverage Δ
...components/FlameGraph/FlameGraphComponent/color.ts 79.37% <75.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee6483...380749f. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Feb 4, 2022

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Result

main pr diff threshold
throughput 220.53 228.63 8.10 (3.61%) 5%
total items processed 65394.00 67840.00 2446.00 (3.67%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope-main:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope-main:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}

Generated by 🚫 dangerJS against fafd229

@eh-am eh-am changed the title chore(frontend): test existing package name extraction from stacktrace feat(frontend): add package coloring for rust Feb 4, 2022
@petethepig petethepig self-requested a review February 7, 2022 03:39
Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for adding this @eh-am !

@petethepig petethepig merged commit c687f83 into main Feb 7, 2022
@petethepig petethepig deleted the chore/test-existing-package-coloring branch February 7, 2022 03:40
@abeaumont
Copy link
Contributor

What would you need for PHP? Opening an issue with it may be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add package coloring for rust
4 participants