New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): add package coloring for rust #798
Conversation
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #798 +/- ##
==========================================
+ Coverage 73.09% 73.12% +0.04%
==========================================
Files 65 65
Lines 2311 2310 -1
Branches 421 421
==========================================
Hits 1689 1689
+ Misses 594 593 -1
Partials 28 28
Continue to review full report at Codecov.
|
ScreenshotsResult
Details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for adding this @eh-am !
What would you need for PHP? Opening an issue with it may be useful. |
Closes #789
This PR contains 2 parts:
Some prep work, adding tests for existing coloring integrations
Couldn't add much tests for
phpspy
since our example is too simple.Plus simplified the
default
one, since it seems to usego
scheme by default.Supports rust
For that the regex used is to just get whatever is before the first
::
.It's a bit naive, since it doesn't deal with cases such as
That @omarabid said it should be treated as
core::future::future::Future::poll
.But should be a good start.